search

sciter-sdk / pysciter

Python bindings for Sciter
https://sciter.com
MIT License
396 stars 40 forks source link

Suggestion not to download the whole SDK but only the required library #56

Open 8ctopus opened 2 years ago

8ctopus commented 2 years ago

I've noticed that only the sciter library is actually required for pysciter to work so it would be possible to use a small script to download the necessary files. Here's an example Let me know if you're interested, I'll happily make it.

8ctopus commented 2 years ago

I ended up doing anyway https://github.com/8ctopus/pysciter-example

pravic commented 2 years ago

Yeah. In fact, that is exactly what we do in CI:

https://github.com/sciter-sdk/pysciter/blob/f5f00112d635f9d1ee98661eeebb2afcaa56c1f4/.travis.yml#L58-L60

8ctopus commented 2 years ago

Thanks for sharing, I see now.

IMO it would suggest remove the requirement to download the whole SDK from the README and add it to the path. Maybe just me, but I don't like big downloads and adding things to PATH. The script installation would provide an alternative.

Also I don't understand what you mean by

...install Sciter shared library to your LIBRARY_PATH.

What's your opinion?