search

scitokens / scitokens-cpp

A C++ implementation of the SciTokens library with a C library interface
Apache License 2.0
5 stars 22 forks source link

Keycache config #105

Closed jhiemstrawisc closed 1 year ago

jhiemstrawisc commented 1 year ago

First pass at creating keycache config api.

djw8605 commented 1 year ago

There's some minor conflicts from the massive async addition. Could you resolve the conflicts, then I think we're good to go.

djw8605 commented 1 year ago

A few build errors.

bbockelm commented 1 year ago

@jhiemstrawisc - can you take another look at this one? Needs a rebase after the big code churns in the last few weeks.

jhiemstrawisc commented 1 year ago

Rebase done, checks passed!

djw8605 commented 1 year ago

I've merged in the linter check, and the code doesn't pass. It did annotate the pull request, though, without useful comments.

I wonder if auto-fix is the only way forward? Since annotations do not give suggested changes?

jhiemstrawisc commented 1 year ago

I'm closing this PR because the git history was damaged. See the new PR #111 to replace this one.