search

sciurius / perl-Text-Layout

Pango style markup formatting for PDF::API2, Markdown, Cairo and more
2 stars 2 forks source link

t/152-pdfbuilder.t failures #11

Closed eserte closed 2 years ago

eserte commented 2 years ago

The test suite of 0.028 fails on most (maybe even all?) of my smokers if PDF::Builder is installed like this:

#   Failed test 'pixel_extents layout y -18'
#   at t/152-pdfbuilder.t line 111.

#   Failed test 'pixel_extents[0] ink y -18'
#   at t/152-pdfbuilder.t line 111.

#   Failed test 'pixel_extents[1] layout y -18'
#   at t/152-pdfbuilder.t line 111.

#   Failed test 'extents[0] ink y -18'
#   at t/152-pdfbuilder.t line 111.

#   Failed test 'extents[1] layout y -18'
#   at t/152-pdfbuilder.t line 111.
# Looks like you failed 5 tests of 31.
t/152-pdfbuilder.t .. 
Dubious, test returned 5 (wstat 1280, 0x500)
Failed 5/31 subtests
sciurius commented 2 years ago

Thanks. Will be fixed in the next update.

PhilterPaper commented 2 years ago

Johan, anything need fixing on my end (PDF::Builder)? I could push out an emergency fix if necessary.

sciurius commented 2 years ago

No worries. One of the incompatible changes in this version of Text::Layout was the orientation of the extents (bounding boxes), and I forgot to adjust the PDF::Builder test for this.

If PDF::Builder uses Text::Layout extents it may be worth checking if that still works.

PhilterPaper commented 2 years ago

There's nothing built into PDF::Builder to use Text::Layout. Aside from a vague mention of Text::Layout as possibly something of interest for PDF::Builder users, I've been waiting for it to settle down before actually incorporating it into Builder (if I end up doing that). See PhilterPaper/Perl-PDF-Builder#95 for some thoughts on the subject.

PhilterPaper commented 2 years ago

Version 0.029 appeared to install correctly on Windows, although perhaps you'd like to get an OK from @eserte before formally closing this.

sciurius commented 2 years ago

This should be fixed now, I see no build failures anymore in the CPAN Testers Matrix.