search

scorelab / Stackle

Stackle is an web communication portal aimed at providing Open Source organizations a platform to have discussions on their github projects and their issues. It provides Github intergration which allows adminstrator of an organization to create a forum thread for the particualr organization. Users signing in is able to view forums of the organizations they contribute to and engage in the forum discussions.
Apache License 2.0
104 stars 146 forks source link

Fix codacy #89

Closed bhavyaagg closed 6 years ago

bhavyaagg commented 6 years ago

@agentmilindu @psnmissaka I have created this PR to fix the codacy issues. I did some research on codacy and found that we can make codacy behave in a way using the .eslintrc.js config file. I have created a config file and reformatted files to follow the same. There are still some issues which will be solved as we reformat other files or add rules for it in the config file.

bhavyaagg commented 6 years ago

Resolved the Merge conflicts.

bhavyaagg commented 6 years ago

@psnmissaka @agentmilindu @padamchopra Can we merge this?

padamchopra commented 6 years ago

@bhavyaagg Just so you know, I actually don't have the merging rights :sweat_smile: I'm the grand prize winner for Score this GCI and contributed to Stackle and Bassa, so that's why I review them. I can only provide additional reviews and not merge the PRs :grimacing:

bhavyaagg commented 6 years ago

@padamchopra Understood man. Congratulations for winning the GCI. I was a GCI mentor this time with JBoss Community. And nevertheless thank you for reviewing the PRs :)

bhavyaagg commented 6 years ago

@psnmissaka @agentmilindu API was not changed in this PR so endpoints will work perfectly.

psnmissaka commented 6 years ago

Please update the PR removing the conflicts.