search

scorphus / thumbor-wand-engine

🧙‍♂️ ImageMagick engine for Thumbor
https://imagemagick.org
MIT License
17 stars 0 forks source link

looks cool ✨ #7

Open gingerlime opened 3 years ago

gingerlime commented 3 years ago

This looks cool. I'm maintaining the thumbor docker image at https://github.com/minimalcompact/thumbor

Would you be interested creating a PR to integrate thumbor-wand-engine into the docker image? happy to help in the process. I would say this should be strictly optional, but could increase adoption if it's available out of the box (or container) ;)

scorphus commented 3 years ago

That would be great, @gingerlime. How should we proceed? What you think is the best option?

gingerlime commented 3 years ago

@scorphus cool. Would you be comfortable opening a PR to add wand-engine into the Docker image? are you comfortable with docker to test it? I can definitely help with adding it to the baseline, but most likely need your help testing that things are working :)

scorphus commented 3 years ago

Would you be comfortable opening a PR to add wand-engine into the Docker image?

Definitely.

are you comfortable with docker to test it?

Comfortable enough, I'd say.

I can definitely help with adding it to the baseline

Awesome! Is there any change made in the past (one or more commits in git history) that may be helpful in some ways?

gingerlime commented 3 years ago

Hey @scorphus sorry for the delay. The main thumbor Dockerfile should be the best starting point I assume? plus the requirements.txt file. In addition, the thumbor configuration lives in a template file that gets parsed to set up the actual config...

Let me know if you have any other questions or need help with anything else :)

scorphus commented 3 years ago

Hey, @gingerlime. Sorry for the delay too.

I gave it a try and it seemed to me that the container runs Python 2. The engine was born after the retirement of Python 2 and I wouldn't like to add support to retired software. Things should move forward :slightly_smiling_face:

I then managed to install Thumbor@master ― with pip3 install git+https://github.com/thumbor/thumbor.git ― after installing python3-pip along with a few other APT packages. Some steps of the installation of Thumbor took very long but eventually I got almost everything working ― I got a strange issue with the watermark filter.

Would you be willing to add support to Python 3 and Thumbor@master as some sort of alpha image release?

gingerlime commented 3 years ago

@scorphus 👋

Yeah, thumbor seems to move a bit slow to python 3 if I'm not mistaken? haven't seen any announcement or much changing, but I'm not following very closely. Definitely keen to get things over to python 3. Take a look at https://github.com/MinimalCompact/thumbor/pull/76 where I started some work in this direction, but it's been kinda quiet on that one for a while ... This should be a good baseline though I think. Please feel free to comment there or ask on Thumbor to see where things are going.

scorphus commented 2 years ago

Hey, @gingerlime :wave:

I'm almost certain you're already aware of thumbor 7 being released recently. I just felt like giving a heads up :slightly_smiling_face:

gingerlime commented 2 years ago

I'm well aware of it :)

scorphus commented 2 years ago

Hey, @gingerlime! What do we do about this issue? Should we transfer it to where changes have to be made to?