search

scottchiefbaker / dool

Python3 compatible fork of dstat
GNU General Public License v3.0
323 stars 64 forks source link

Catch OverflowError #16

Closed jkleckner closed 1 year ago

jkleckner commented 2 years ago
ISSUE TYPE
DSTAT VERSION
Dool 1.0.0
SUMMARY

This is an application of the patch to dstat described here:

jkleckner commented 2 years ago

Rebased to master.

jkleckner commented 2 years ago

Rebased to master

jkleckner commented 1 year ago

Rebased again. Is this patch of any interest?

scottchiefbaker commented 1 year ago

Apologies... Github was not sending me alerts for issues and pull requests on this repo. I did not see this until just now.

Is this still relevant? I'm working through some backlog.

SuperTux88 commented 1 year ago

Yes, this is still relevant.

jkleckner commented 1 year ago

Rebased again.

jkleckner commented 1 year ago

I use this with the patch and it is necessary for me.

scottchiefbaker commented 1 year ago

Before I merge this I need a little more information. What overflow is this catching, and how is it triggered?

jkleckner commented 1 year ago

This bug report details the disk IO overflow pretty well:

https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619

SuperTux88 commented 1 year ago

It also crashes sometimes when adding/removing network interfaces (connecting/disconnecting VPN).

scottchiefbaker commented 1 year ago

Does this address the random "OverflowError: cannot convert float infinity to integer" from #3?

jkleckner commented 1 year ago

Does this address the random "OverflowError: cannot convert float infinity to integer" from #3?

Probably, yes.

scottchiefbaker commented 1 year ago

@jkleckner EXCELLENT. That has been one of my personal pet peeves for 12+ months now.