search

scottchiefbaker / dool

Python3 compatible fork of dstat
GNU General Public License v3.0
323 stars 64 forks source link

Optional ANSI 16-color theme #18

Closed leahneukirchen closed 1 year ago

leahneukirchen commented 2 years ago
SUMMARY

dool now uses 256-colors which doesn't fit into my terminal emulator color scheme.

ISSUE TYPE

Would you accept a patch that re-enables the old 16-color scheme as an option?

malventano commented 1 year ago

The ANSI changes of 1.1.0 break the bottom line colors even in 256 color terminals (dstat for reference): image Along with the ability to re-enable the old scheme, dool should probably check the $TERM type and revert as necessary.

scottchiefbaker commented 1 year ago

Yes... if you wrote a patch for a 16 color terminal I would accept it.

How does the 256 color scheme NOT fit in to your terminal emulator?

leahneukirchen commented 1 year ago

I probably didn't make myself very clear: A terminal color theme defines the colors for the 16 base colors. The 256 colors are the same for every terminal. So if I want dool to use my terminal color scheme, it should only use the base 16 colors.

leahneukirchen commented 1 year ago

I have a patch for this, will PR.

scottchiefbaker commented 1 year ago

@malventano can you open a separate issue for the bottom line colors? I'm not able to reproduce.

scottchiefbaker commented 1 year ago

@malventano I just landed 5371f754 which might address your color concerns.

scottchiefbaker commented 1 year ago

This has been added as the --color16 option