search

scrapinghub / dateparser

python parser for human readable dates
BSD 3-Clause "New" or "Revised" License
2.57k stars 465 forks source link

Update zh data #1148

Closed serhii73 closed 1 year ago

RadhiFadlillah commented 1 year ago

If you don't mind, I'm wondering why does the modification in this PR are done directly in CLDR JSON file?

From what I understand, those CLDR files are synced periodically with the upstream repo,so it shouldn't be modified. Instead, we should modify the supplemental *.yaml file which later will be merged with the CLDR data.

Is my understanding correct? Or have there been recent changes to the way translations are contributed?

Gallaecio commented 1 year ago

You are right, we should only be modifying YAML files.

@serhii73 It is probably OK for now, but whenever we update the CLDR JSON files from upstream next, we may need to check if what we added here exists upstream, and if not, we would need to move the data to the YAML files to make sure it is included going forward.