search

scrapli / scrapli_netconf

Fast and flexible Python 3.7+ netconf client specifically for network devices
https://scrapli.github.io/scrapli_netconf/
MIT License
93 stars 6 forks source link

Catches more variants of server capabilities supporting 'with-defaults' #129

Closed sanjmonkey closed 1 year ago

sanjmonkey commented 1 year ago

Description

Fixes https://github.com/scrapli/scrapli_netconf/issues/128

Type of change

How Has This Been Tested?

Tests updated with sample live device capability string

codecov[bot] commented 1 year ago

Codecov Report

Merging #129 (e2c553b) into main (932575c) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   76.14%   76.14%           
=======================================
  Files          16       16           
  Lines        1002     1002           
=======================================
  Hits          763      763           
  Misses        239      239
Impacted Files Coverage Δ
scrapli_netconf/driver/base_driver.py 96.97% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

carlmontanari commented 1 year ago

thanks for the work on this, lgtm!

sanjmonkey commented 1 year ago

All good, love the project!