search

scrapy-plugins / scrapy-playwright

🎭 Playwright integration for Scrapy
BSD 3-Clause "New" or "Revised" License
1.04k stars 112 forks source link

Unused 'spider' parameter in '_create_browser_context' method #211

Closed lishukan closed 1 year ago

lishukan commented 1 year ago
image

_create_browser_context has a parameter named 'spider' ,is optional。 But is handler.py, you can find that the spider parameter never receive a value when called.

image
elacuesta commented 1 year ago

A good catch, thank you.