scrapy-plugins / scrapy-playwright

🎭 Playwright integration for Scrapy
BSD 3-Clause "New" or "Revised" License
1.03k stars 113 forks source link

Keyword arguments for PLAYWRIGHT_PROCESS_REQUEST_HEADERS, pass additional Request fields #303

Closed elacuesta closed 4 months ago

elacuesta commented 4 months ago

Deprecate passing arguments positionally to the function defined in PLAYWRIGHT_PROCESS_REQUEST_HEADERS, pass them as keyword instead. Pass additional data about the Scrapy request, not just the headers.

Tasks:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (5b8cfd7) to head (4098004).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #303 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 6 6 Lines 598 603 +5 ========================================= + Hits 598 603 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.