search

scrapy-plugins / scrapy-zyte-api

Zyte API integration for Scrapy
BSD 3-Clause "New" or "Revised" License
36 stars 19 forks source link

Handle custom attributes received in the API response. #213

Closed wRAR closed 2 months ago

wRAR commented 3 months ago

Requires https://github.com/zytedata/zyte-common-items/pull/100

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.86%. Comparing base (c1ba9c0) to head (b7e22e7). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #213 +/- ## ========================================== + Coverage 97.69% 97.86% +0.16% ========================================== Files 14 14 Lines 1564 1590 +26 Branches 330 337 +7 ========================================== + Hits 1528 1556 +28 + Misses 15 14 -1 + Partials 21 20 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/scrapy-plugins/scrapy-zyte-api/pull/213?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy-plugins) | Coverage Δ | | |---|---|---| | [scrapy\_zyte\_api/\_\_init\_\_.py](https://app.codecov.io/gh/scrapy-plugins/scrapy-zyte-api/pull/213?src=pr&el=tree&filepath=scrapy_zyte_api%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy-plugins#diff-c2NyYXB5X3p5dGVfYXBpL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [scrapy\_zyte\_api/\_annotations.py](https://app.codecov.io/gh/scrapy-plugins/scrapy-zyte-api/pull/213?src=pr&el=tree&filepath=scrapy_zyte_api%2F_annotations.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy-plugins#diff-c2NyYXB5X3p5dGVfYXBpL19hbm5vdGF0aW9ucy5weQ==) | `100.00% <100.00%> (+4.16%)` | :arrow_up: | | [scrapy\_zyte\_api/providers.py](https://app.codecov.io/gh/scrapy-plugins/scrapy-zyte-api/pull/213?src=pr&el=tree&filepath=scrapy_zyte_api%2Fproviders.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy-plugins#diff-c2NyYXB5X3p5dGVfYXBpL3Byb3ZpZGVycy5weQ==) | `94.65% <100.00%> (+0.50%)` | :arrow_up: |
wRAR commented 3 months ago

(some test failures related to field overrides)

Gallaecio commented 3 months ago

I’ll handle the update of https://github.com/scrapy-plugins/scrapy-zyte-api/blob/a1d81d11854b420248f38e7db49c685a8d46d943/scrapy_zyte_api/_params.py#L25 since I am already refactoring it significantly as part of SERP work.

wRAR commented 2 months ago

We should release zyte-common-items before merging this I think.

kmike commented 2 months ago

@wRAR feel free to merge when you think it's ready.