scrapy / parsel

Parsel lets you extract data from XML/HTML documents using XPath or CSS selectors
BSD 3-Clause "New" or "Revised" License
1.15k stars 146 forks source link

Selector text tests #236

Closed shahidkarimi closed 2 years ago

shahidkarimi commented 2 years ago

Unit tests covering selector get() and getall() method

codecov[bot] commented 2 years ago

Codecov Report

Merging #236 (857ca72) into selector-text (859044c) will increase coverage by 2.87%. The diff coverage is n/a.

:exclamation: Current head 857ca72 differs from pull request most recent head 7941093. Consider uploading reports for the commit 7941093 to get more accurate results

@@                Coverage Diff                @@
##           selector-text     #236      +/-   ##
=================================================
+ Coverage          94.88%   97.76%   +2.87%     
=================================================
  Files                  5        5              
  Lines                313      313              
  Branches              67       67              
=================================================
+ Hits                 297      306       +9     
+ Misses                13        3      -10     
- Partials               3        4       +1     
Impacted Files Coverage Δ
parsel/selector.py 96.00% <0.00%> (+5.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 859044c...7941093. Read the comment docs.

kmike commented 2 years ago

Thanks for the help @shahidkarimi!