search

scrapy / scrapyd

A service daemon to run Scrapy spiders
https://scrapyd.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
2.98k stars 569 forks source link

scrapyd deploy with slash in branch name causes problems #52

Closed kevinkirkup closed 7 years ago

kevinkirkup commented 10 years ago

If you try to deploy a project with scrapyd-deploy and your current branch has a slash in the name, it will say the deploy was successful, but doesn't update the project.

Example Branch Name: feature/some-feature

Changing the branch name solve the problem.

Digenis commented 7 years ago

@kevinkirkup, I guess you deploy using git versioning instead of timestamp. This is related to #117, slashes are also not escaped.

I'm closing this in favour of #117 which is more detailed.