search

scrapy / scurl

Performance-focused replacement for Python urllib
Apache License 2.0
21 stars 6 forks source link

Fix urlsplit #13

Closed malloxpb closed 6 years ago

malloxpb commented 6 years ago

For this PR, I implemented parsing based on what was implemented in GURL class :) #12

malloxpb commented 6 years ago

Running the performance test gives 0.18sec for urlsplit and urljoin, which is expected 😄

malloxpb commented 6 years ago

Hey @lopuhin, thank you so much for the review. I have optimized the code as you have suggested. Can you take a look at it when you have time 😄

lopuhin commented 6 years ago

Looks great, thanks @nctl144 !