search

scrapy / scurl

Performance-focused replacement for Python urllib
Apache License 2.0
21 stars 6 forks source link

Python2 support for Scurl #29

Closed malloxpb closed 6 years ago

malloxpb commented 6 years ago

This PR aims to support python2 on Scurl

codecov[bot] commented 6 years ago

Codecov Report

Merging #29 into master will increase coverage by 2.41%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   86.08%   88.49%   +2.41%     
==========================================
  Files           2        2              
  Lines         309      313       +4     
==========================================
+ Hits          266      277      +11     
+ Misses         43       36       -7
Impacted Files Coverage Δ
scurl/canonicalize.pyx 86.59% <100%> (+8.24%) :arrow_up:
scurl/cgurl.pyx 89.35% <75%> (-0.28%) :arrow_down:
malloxpb commented 6 years ago

hey @lopuhin , I made this PR to support Py2 for this project. Let me know what you think :)

malloxpb commented 6 years ago

Thank you, Konstantin!

lopuhin commented 6 years ago

Thank you @nctl144 ! Btw, I noticed that in setup.py we don't list python 3 compatibility, only 2.7: https://github.com/nctl144/scurl/blob/9264a1ed234a63ff720d6c9e68680fb3c7f044ca/setup.py#L84

malloxpb commented 6 years ago

Yeah I haven't taken a look at the setup.py yet and it was still the one I got from urlparse4 😆 . I will fix it now :)