scrapy / scurl

Performance-focused replacement for Python urllib
Apache License 2.0
21 stars 6 forks source link

Raise the exception error for invalid urls #31

Closed malloxpb closed 6 years ago

malloxpb commented 6 years ago

In the test file, there are some invalid ipv6 urls that SCURL does not raise exception error as can be seen in this comment. We will need to work on implementing this to pass the test :) Those invalid urls can be found here with the invalid urls are:

'http://::12.34.56.78]/',
'http://[::1/foo/',
'ftp://[::1/foo/bad]/bad',
'http://[::1/foo/bad]/bad',
'http://[::ffff:12.34.56.78'

This can probably be fixed by adding exception handling in this class, according to this and this from python repository

lopuhin commented 6 years ago

Could you please link to the test you mean here @nctl144 while your memory is fresh? (and include the revision in the link so that it stays relevant)

malloxpb commented 6 years ago

Sure I will edit the first comment :)

malloxpb commented 6 years ago

This has been resolved