scrapy / scurl

Performance-focused replacement for Python urllib

Apache License 2.0

21 stars 6 forks source link

keep canonicalize the same as that of w3lib #36

Closed malloxpb closed 6 years ago

malloxpb commented 6 years ago

This PR aims to make canonicalize_url from scurl the same with the func from w3lib

malloxpb commented 6 years ago

Hey @lopuhin , I realized that GURL has nothing to do with this, it's just that I commented out a part of the code in canonicalize_url (which is this line) that was supposed to uppercase those special characters :(

codecov[bot] commented 6 years ago

Codecov Report

Merging #36 into master will increase coverage by 1.66%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   88.46%   90.12%   +1.66%     
==========================================
  Files           2        2              
  Lines         312      314       +2     
==========================================
+ Hits          276      283       +7     
+ Misses         36       31       -5

Impacted Files	Coverage Δ
scurl/canonicalize.pyx	`91.83% <100%> (+5.37%)`	:arrow_up: