scrapy / scurl

Performance-focused replacement for Python urllib

Apache License 2.0

21 stars 6 forks source link

A fix for urljoin #41

Closed malloxpb closed 6 years ago

malloxpb commented 6 years ago

With this PR, double parsing in urljoin is removed and the performance is improved significantly.

codecov[bot] commented 6 years ago

Codecov Report

Merging #41 into master will decrease coverage by 0.92%. The diff coverage is 50%.

@@            Coverage Diff            @@
##           master     #41      +/-   ##
=========================================
- Coverage   90.12%   89.2%   -0.93%     
=========================================
  Files           2       2              
  Lines         314     315       +1     
=========================================
- Hits          283     281       -2     
- Misses         31      34       +3

Impacted Files	Coverage Δ
scurl/cgurl.pyx	`88.01% <50%> (-1.34%)`	:arrow_down: