scrapy / scurl

Performance-focused replacement for Python urllib

Apache License 2.0

21 stars 6 forks source link

Fix urljoin test #56

Closed malloxpb closed 5 years ago

malloxpb commented 6 years ago

This PR aims to resolve the issue #55 , which fixes the urljoin tests that does not test anything (assertRaises without func name and params)

codecov[bot] commented 6 years ago

Codecov Report

Merging #56 into master will increase coverage by 0.28%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage    61.6%   61.89%   +0.28%     
==========================================
  Files           3        3              
  Lines         349      349              
==========================================
+ Hits          215      216       +1     
+ Misses        134      133       -1

Impacted Files	Coverage Δ
scurl/scurl_helper.pxd	`63.41% <0%> (+2.43%)`	:arrow_up: