scratchfoundation / scratch-gui

Graphical User Interface for creating and running Scratch 3.0 projects.
https://scratchfoundation.github.io/scratch-gui/develop/
BSD 3-Clause "New" or "Revised" License
4.43k stars 3.51k forks source link

Share button, (inactive) Shared button, or Remix button should appear when appropriate #3466

Closed benjiwheeler closed 5 years ago

benjiwheeler commented 5 years ago

Follow on to https://github.com/LLK/scratch-gui/issues/3444

Carl shared designs that make the Share button show "Shared" when the project has been shared, and that have a Remix button in its place when remixing is possible and shared is not (that is, when the user is logged in, but does not own the project.)

We should implement these.

Designs: https://projects.invisionapp.com/d/main#/console/15762036/327192535/preview

towerofnix commented 5 years ago

While not entirely related, I'd like to bring up the topic of some users intentionally creating remixes of their own projects (using a sort-of glitch with login sessions) in useful ways. For example, @TheLogFather does this frequently. If a user views Simpler motion panorama demo, they can see that it is a remix of (the same user's!) Panorama, mouse-panning (which is itself a remix of that user's other account's 3D Terrain Engine v0.11). That ends up displaying as this:

"Thanks to TheLogFather for Panorama, mouse-panning (Project Remixed); Thanks to DadOfMrLog for 3D Terrain Engine v0.11 (Original Project)"

So as seen, remixing your own projects can be used as a way of presenting a structure of related projects, even if they're your own.

Do note that "File -> Save as a Copy" exists, but that it doesn't do the same thing: it just duplicates the project, removing the "Project Remixed" message, hence defeating the point of remixing your own project in the first place.

So for discussion: Should a way to "officially" do this be considered? Like I mentioned, you need to manipulate your login session to make this work presently:

There is a bug that allows you to remix your own project. First log into another account (such as a test account). Open a new tab and see inside one of your main account's projects. Then in the first tab switch back to your main account. On the second tab click ”remix“. This will not only give you a copy of your project, but also make it show up in the remix tree.

That obviously just is not a very convenient way to access a handy semi-feature.

benjiwheeler commented 5 years ago

Thanks for that perspective, @towerofnix -- I definitely wouldn't have thought of that!

I made an issue for that question, at https://github.com/LLK/scratch-gui/issues/3501

benjiwheeler commented 5 years ago

Re: design, I removed the label because I spoke to @carljbowman and he said we should not use an icon for Share for the time being (none has been determined yet), but we should use the spiral svg for the Remix button.

benjiwheeler commented 5 years ago

@carljbowman, one last thought -- could it make sense to have hover styles that alter the appearance of these buttons somewhat?

benjiwheeler commented 5 years ago

screenshots of what @paulkaplan and I made: (these all show when user is logged in)

screen shot 2018-10-26 at 9 31 46 am screen shot 2018-10-26 at 9 33 06 am screen shot 2018-10-26 at 9 34 18 am