search

scripting / drummerSupport

Support for Drummer users.
19 stars 0 forks source link

How is hoisting working for you? #47

Open scripting opened 3 years ago

scripting commented 3 years ago

I may have seen some problems, not sure if they're related to hoisting.

If you're using hoisting in your regular Drummer work, how's it going?

akaKenSmith commented 3 years ago

I refreshed my human memory about how hoisting works a couple of weeks ago and used it then for a few minutes to let it sink in: I had no problems back then but that's ancient history at this point, I'm sure. It's not part of my regular work habits.

I tried it again just now, web version, and it seemed fine. I hoisted and dehoisted a section of an outline, but then I wanted to see if I could place the hoisted section in the bookmarks and things went astray. Now I'm looking at the most recent contents of my bookmark menu in the middle of the outline I had just been hoisting in, in a new tab named after that outline rather than named bookmarks. In the attributes, the name Bookmarks is nowhere to be seen and it's not in the list of files that drop down when I click Open in the Files menu.

I have repeated this three times now and it seems the same each time. At the top of the bookmark listing opened in the tab (with the wrong tab name) I now have three list items with the name of the outline I had been working on when I tried to bookmark a tabbed outline.

I think that's all accurate but I'm happy to try to say more if I can. I went into the attributes, restored the name Bookmarks, erased the other content of that outline, and things look normal again.

scripting commented 3 years ago

@akaKenSmith -- great testing and great error reporting. I'm proud of you my English prof friend! 👍

scripting commented 3 years ago

@akaKenSmith -- I'm trying to track this down, and found it isn't specific to Bookmarks, I can make it happen by opening any file with something hoisted.

scripting commented 3 years ago

@akaKenSmith -- I believe I have fixed the problem with bookmarking while hoisted.

Please reload Drummer, and then try repeating the steps and confirm that it behaves as you would expect.

I was worried that this would be a hairy problem, but it wasn't. I forgot to reset the hoist stack when switching to the new tab, so the data in the bookmarks.opml file was wildly inconsistent, which accounts for the crazy shit we saw. It was interesting, but very very wrong.

It's even worse than it appears

Also this was a more general problem as I said in the previous comment, 4 hours ago. You could make it fail by simply:

  1. Hoist something.

  2. Open a file.

Boom. Everything in the newly opened file is fubar.

akaKenSmith commented 3 years ago

I kicked the tires and drove it around the block--it looks fixed to me. It's a good feature, adding a fine-grain option to bookmarking.

scripting commented 3 years ago

@akaKenSmith -- good teamwork. this was a milestone in debugging.

scripting commented 3 years ago

Just posted a change note.

akaKenSmith commented 3 years ago

I now think there is one more aspect to this problem. Web version.

Immediately after hoisting, I expect Dehoist to be highlighted--offered as a live option--in the drop-down Outliner menu. And so it is.

But (immediately after hoisting) if I open another file, then go back to the just-hoisted outline, I am no longer offered a highlighted, live Dehoist in the drop-down OUtliner menu. Dehoist has grayed out.

I believe I can currently reproduce this effect as many times as I want.

Question, related or not, I don't know: Am I still supposed to be seeing v2.0.7 up in the corner? I did empty the cache and reload about an hour ago as I was trying to pin down this pattern.

scripting commented 3 years ago

posted a change note about version numbers.

scripting commented 3 years ago

@akaKenSmith -- I believe this bug is fixed now.

Will post a change note.

akaKenSmith commented 3 years ago

Looks like it's fixed, I agree.

scripting commented 3 years ago

@akaKenSmith -- please keep looking. this one was huge. i expect there are other problems still lurking in the hoisting stuff.

akaKenSmith commented 3 years ago

@scripting, I am still looking at hoist, open file, bookmark in some kind of conjunction because I'm still occasionally seeing the bookmark outline drop itself into where I was hoisting in another outline and that outline becoming what I see in the drop-down bookmark listing. But I can't reproduce this by following known steps. Can't find the reproducible steps to describe.

scripting commented 3 years ago

@akaKenSmith -- checking in. how's it going? are you still seeing the weirdness you reported in the previous comment?

akaKenSmith commented 3 years ago

All I see right now is in a leftover damaged outline from my amateur detective work from yesterday. I had an outline I created and filled with some content for that work.

In the process, that outline was damaged in the whole Hoist & Open a file operation. Much of the outline was lost, and that's still the case. The name that appears on the tab was changed yesterday, too--that's also still true of that outline. I know how to fix that--I did so more than once yesterday while I was trying things out: by opening up and changing the language in the Set title & Edit OPML headers area.

So I believe all I am seeing right now if leftover damage from before the fix.

akaKenSmith commented 3 years ago

I spent a little time with hoisting and tab changes today and couldn't get anything to misbehave.

scripting commented 3 years ago

thanks ken, this is the kind of thing that gives me nightmarish dreams. ;-)