search

scrollmapper / bible_databases

Bible versions and cross-reference databases.
977 stars 346 forks source link

bible-mysql.sql attempts to drop USERS table from core mysql database #75

Open mrfusi0n opened 1 year ago

mrfusi0n commented 1 year ago

I don't believe this is intended to be malicious but the bible-mysql.sql script not only creates/recreates thebible database but also attempts to create/recreate the core mysql database! If someone attempted to load this onto an existing MySQL or MariaDB database using root privileges, it would wipe out all existing users (and more).

bible-mysql.sql line 1096: DROP TABLE IF EXISTS `user`;

I believe the solution is to remove everything non-bible related - i.e. everything below line 337 in bible-mysql.sql. I can submit a PR if that would be helpful.

JohnMayes commented 11 months ago

This just bit me. My fault for not inspecting the script beforehand I guess. Thankfully I didn't loose anything to serious (other than my time), but it would be really nice if #69 was merged to prevent this kind of thing in the future.