Withdraw screen not showing correct number of pooled tokens

scrtlabs / EthereumBridgeFrontend

Frontend for the Ethereum<>Secret Network bridge

Other

9 stars 22 forks source link

Withdraw screen not showing correct number of pooled tokens #143

Open secretchaingirl opened 3 years ago

secretchaingirl commented 3 years ago

I provided liquidity for this sSCRT/SEFI pair. The total tokens is > 17 but the individual tokens are showing an amount of "0". And pool share, although it's a small percentage, shouldn't say "0%" should it? It's probably pretty low but it can get confusing for users. Maybe just change it to "< 1%" or something similar if no decimal value is desired.

alejandrordzl commented 3 years ago

The UI team reviewed the function used to display the percentage, we discovered that 0% is used as a default value so we suspect the backend is either not returning a value or returning error.

We are turning this over to Enigma team for troubleshooting.

cankisagun commented 3 years ago

cc @Cashmaney @assafmo

assafmo commented 3 years ago

Yes, it seems that the backend does not return this pool's values, do you see any errors in the console or network tabs? @lauraweindorf is this still an issue for you?

secretchaingirl commented 3 years ago

yeah, still seeing an issue after providing liquidity and then going to the Withdraw screen. The pooled SEFI and sSCRT plus my pool share are all showing 0.

cankisagun commented 3 years ago

@David-Sod pls see the same comment in #142 - these work fine in the current UI, you must have missed something ![Uploading image.png…]()

alejandrordzl commented 3 years ago

@lauraweindorf @cankisagun .Yes, this was related to issue #142. This issue was solved with yesterday's commit, moving this to Done