search

sct / overseerr

Request management and media discovery tool for the Plex ecosystem
https://overseerr.dev
MIT License
3.76k stars 437 forks source link

Removed root folders continue being used for requests #3373

Open i-am-at0m opened 1 year ago

i-am-at0m commented 1 year ago

Description

I've moved my libraries around on my storage, updated root folders in Sonarr and Radarr, and updated the default root folders in Overseerr. When selecting a root folder for a request from the drop-down, the old paths don't exist.

However, the default entry for my users that just hit request->submit is the old root folder, which means they get submitted to Sonarr with an invalid root folder (since the old paths don't exist any more) and refuse to download unless I change them in Sonarr. I've seen the same behavior with Radarr.

On the admin account, it seems like changing the root folder in a request once has cleared the old root folders from the drop-down and they aren't selectable, but it was affecting that account as well at first.

Version

1.32.5

Steps to Reproduce

Cannot reproduce with the admin account

Screenshots

No response

Logs

No response

Platform

smartphone

Device

Pixel 7 Pro

Operating System

Synology 1019+

Browser

Chrome

Additional Context

No response

Code of Conduct

i-am-at0m commented 1 year ago

I figured this out. When you remove a root folder, it clears the default drop-down in the service setting. If there is nothing selected there, no matter what root folder you select in the request, it uses the previous - deleted and un-selected/selectable - root folder instead of what's in the request.

After I set the new default, the issue stopped, but that doesn't stop any of this being unintended behavior. I selected one of the valid options for a root folder for the show in the request, but what was getting sent to Sonarr was not that root folder, it was one that didn't even exist any more.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

i-am-at0m commented 1 year ago

I mean, it hasn't been fixed yet...?

willquill commented 1 year ago

I figured this out. When you remove a root folder, it clears the default drop-down in the service setting. If there is nothing selected there, no matter what root folder you select in the request, it uses the previous - deleted and un-selected/selectable - root folder instead of what's in the request.

After I set the new default, the issue stopped, but that doesn't stop any of this being unintended behavior. I selected one of the valid options for a root folder for the show in the request, but what was getting sent to Sonarr was not that root folder, it was one that didn't even exist any more.

I can 100% confirm that as of June 4th, 2023, this issue is still occurring, and this is the manual resolution.

My situation:

  1. Root folder is /movies, and Overseerr and Radarr work fine together. Radarr had other root folders available at this time, but I didn't use them with Overseerr. My other root folders were /movies/Halloween and /movies/Christmas.
  2. In Radarr, I changed my root folder to /data/media/movies and used the Movie Editor to edit all movies to the new root folder. At the same time, I removed all previous root folders (the three mentioned above).
  3. When manually adding a movie to Radarr, the new path is my only path and also, obviously, the default path for new movies.
  4. When requesting a movie in Overseerr, it continues to create new movies in Radarr under the /movies path, which doesn't exist.
  5. My download client downloads and unpacks the movie, and then it sits in completed.
  6. I went into Overseerr > Radarr settings and changed the "Root Folder" value from "Select root folder" to "/data/media/movies", new movie requests work just fine.

It would be great Overseerr functioned like this:

  1. Periodically sync with Radarr to verify the root folder selected in Overseerr matches a root folder in Radarr. If it detects the Overseerr-selected folder no longer exists, update it to the existing Radarr root folder.
  2. Same with Sonarr.
i-am-at0m commented 1 year ago

I would personally rather get a config error notification than an automatic settings change. If new requests won't process because the default is invalid, it telegraphs you need to go fix something instead of silently "fixing" it in possibly an incorrect way.

On Sun, Jun 4, 2023, 22:56 Will Coquillette @.***> wrote:

I figured this out. When you remove a root folder, it clears the default drop-down in the service setting. If there is nothing selected there, no matter what root folder you select in the request, it uses the previous - deleted and un-selected/selectable - root folder instead of what's in the request.

After I set the new default, the issue stopped, but that doesn't stop any of this being unintended behavior. I selected one of the valid options for a root folder for the show in the request, but what was getting sent to Sonarr was not that root folder, it was one that didn't even exist any more.

I can 100% confirm that as of June 4th, 2023, this issue is still occurring, and this is the manual resolution.

My situation:

  1. Root folder is /movies, and Overseerr and Radarr work fine together. Radarr had other root folders available at this time, but I didn't use them with Overseerr. My other root folders were /movies/Halloween and /movies/Christmas.
  2. In Radarr, I changed my root folder to /data/media/movies and used the Movie Editor to edit all movies to the new root folder. At the same time, I removed all previous root folders (the three mentioned above).
  3. When manually adding a movie to Radarr, the new path is my only path and also, obviously, the default path for new movies.
  4. When requesting a movie in Overseerr, it continues to create new movies in Radarr under the /movies path, which doesn't exist.
  5. My download client downloads and unpacks the movie, and then it sits in completed.
  6. I went into Overseerr > Radarr settings and changed the "Root Folder" value from "Select root folder" to "/data/media/movies", new movie requests work just fine.

It would be great Overseerr functioned like this:

  1. Periodically sync with Radarr to verify the root folder selected in Overseerr matches a root folder in Radarr. If it detects the Overseerr-selected folder no longer exists, update it to the existing Radarr root folder.
  2. Same with Sonarr.

— Reply to this email directly, view it on GitHub https://github.com/sct/overseerr/issues/3373#issuecomment-1575962394, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHROW6ZRPXGAHM3FFMFU53XJVDHHANCNFSM6AAAAAAVPZ7MTE . You are receiving this because you authored the thread.Message ID: @.***>

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

danshilm commented 6 months ago

We cache the response from Radarr when fetching the Radarr server's configuration (things like root folders, quality profiles, etc). So this is very likely just the cache not being invalidated correctly or the stale value from the cache being used. I've tagged the issue accordingly and also excluding this issue from stalebot.