scylladb / gemini

Test data integrity by comparing against an Oracle running in parallel
Apache License 2.0
27 stars 16 forks source link

fix(store): add simple compare in Check function to avoid complex diff generation #391

Closed illia-li closed 11 months ago

illia-li commented 11 months ago

Check function works extremely slow then responses has not nil data. You can see this if compare read operations count with warmup and without warmup on same schema. It's related with fill oldValues chans during warmup. Or if you try to force validations only with oldValues chans. reflect.DeepEqual works up to 10 times faster that old logic with sort rows and diff generation. And no need to sort rows and to try generate diff in cases with same testRows and oracleRows.