search

sdm660-mainline / linux

Linux-sdm660 kernel source tree
Other
27 stars 17 forks source link

Panel driver for both clover variants unified #41

Closed minlexx closed 1 month ago

minlexx commented 1 month ago

Both drivers are based on the same controller and are so similar that only init sequence is different (and even that is very similar). And of course panel resolution and physical size + timings differ too. So it is very easy to have both panels supported in a single driver.

dmesg with this booting: https://paste.sr.ht/~minlexx/07061611fd322e727c021d386b5648cee38af1c5

minlexx commented 1 month ago

qcom-spmi-gpio 800f000.spmi:pmic@2:gpio@c000: invalid function gpio in map table

there are probably no variations of functions on pmic gpio, so setting function is redundant. I'll recheck

EDIT: there are variations

minlexx commented 1 month ago

This works very well now.

I like how one panel driver can handle both variants - less headache with which modules to include into initramfs for which device variant, etc. Most other drivers also do this for various panels on single controller, so I think this is completely fine and upstreamable solution.