Added default base virtual address

[bdevierno1]

Added Default base virtual address

Summary:

Updated script to set base address to 0x7f000000000. Users may still update the address using the -a flag. Resolves issue 100 and 186

Usage:

This PR includes
Resolves issues	👍 NFs crashing when default -a argument not passed in
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

• Dependencies: None

TODO before merging :

• [x] PR is ready for review

Test Plan:

Ensured that NFs did not crash when running without the user setting address. Ensured that if a default base virtual address value is passed in to the go script, the one that is provided overrides the default. Tested with the diff number of huge pages as well as default ONVM_NUM_HUGEPAGES=1024 as per install guide.

Review:

[onvm]

In response to PR creation

CI Message

Your results will arrive shortly

[kevindweb]

https://serverfault.com/questions/52034/what-is-the-difference-between-double-and-single-square-brackets-in-bash We should also be using double square brackets as seen in other places in our bash scripts. '[[' not '['. We don't have it everywhere but it is normally safer.

[kevindweb]

Sorry about the nitpicking, but we don't do as much commenting as we should, so we should make it the best it can be.

[bdevierno1]

Sorry about the nitpicking, but we don't do as much commenting as we should, so we should make it the best it can be.

@kevindweb No worries. Helps me learn as well! 👍 Thanks

[kevindweb]

@bdevierno1 Thanks for updating, I'll test it in the cluster later this week

[kevindweb]

@onvm test it pls

[onvm]

@onvm test it pls

CI Message

Your results will arrive shortly