Closed bdevierno1 closed 4 years ago
In response to PR creation
Your results will arrive shortly
https://serverfault.com/questions/52034/what-is-the-difference-between-double-and-single-square-brackets-in-bash We should also be using double square brackets as seen in other places in our bash scripts. '[[' not '['. We don't have it everywhere but it is normally safer.
Sorry about the nitpicking, but we don't do as much commenting as we should, so we should make it the best it can be.
Sorry about the nitpicking, but we don't do as much commenting as we should, so we should make it the best it can be.
@kevindweb No worries. Helps me learn as well! 👍 Thanks
@bdevierno1 Thanks for updating, I'll test it in the cluster later this week
@onvm test it pls
@onvm test it pls
Your results will arrive shortly
Added Default base virtual address
Summary:
Updated script to set base address to 0x7f000000000. Users may still update the address using the -a flag. Resolves issue 100 and 186
Usage:
Merging notes:
TODO before merging :
Test Plan:
Ensured that NFs did not crash when running without the user setting address. Ensured that if a default base virtual address value is passed in to the go script, the one that is provided overrides the default. Tested with the diff number of huge pages as well as default ONVM_NUM_HUGEPAGES=1024 as per install guide.
Review: