sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
263 stars 135 forks source link

Advanced rings fix #212

Closed dennisafa closed 4 years ago

dennisafa commented 4 years ago

The fixes the stats issue we were having, where tx pps wasn't properly counted.

Summary:

Previously the advanced rings NF's would enqueue packets onto its TX ring and let that thread decide what to do next with the packet. This way, stats were not properly updated. Directly handling transmission of the packets fixes that.

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes X
Usability improvements
Bug fixes X
New functionality
New NF/onvm_mgr args
Changes to starting NFs X
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Run the scaling_example NF to make sure the stats are properly updating, as well as the token bucket NF

Review:

(optional) << @-mention people who should review these changes >> @sdnfv/gw-undergrads

onvm commented 4 years ago

In response to PR creation

CI Message

Your results will arrive shortly

dennisafa commented 4 years ago

high priority so that we can get the token bucket NF approved/changed

koolzz commented 4 years ago

@onvm do the thing

onvm commented 4 years ago

@onvm do the thing

CI Message

Your results will arrive shortly