Closed bdevierno1 closed 4 years ago
In response to PR creation
Your results will arrive shortly
Can we get a link to/screenshots of it passing the test cases for forward_tb.c
?
Can we get a link to/screenshots of it passing the test cases for
forward_tb.c
?
I have added an image to the pr summary.
@kevindweb I have removed the comment bot from the branch job as well.
sounds good to me
Update verbosity
Summary:
Increase verbosity levels. Styling for c code --indentation and naming convention-- will no longer be checked. Deleted the comment bot. When I made the PR it failed to comment. Was the first time that had happened but since it was more of a 'nice to have' I have opted to remove it.
Apologies for the inconvenience in having to review these changes.
Usage:
Merging notes:
TODO before merging :
Test Plan:
Tested with forward.c in https://github.com/sdnfv/openNetVM/pull/199/files . ./style/run-lint.sh c outputs zero errors.
Review:
@kevindweb @dennisafa