search

sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
263 stars 135 forks source link

Update verbosity #213

Closed bdevierno1 closed 4 years ago

bdevierno1 commented 4 years ago

Update verbosity

Summary:

Increase verbosity levels. Styling for c code --indentation and naming convention-- will no longer be checked. Deleted the comment bot. When I made the PR it failed to comment. Was the first time that had happened but since it was more of a 'nice to have' I have opted to remove it.

Apologies for the inconvenience in having to review these changes.

Usage:

This PR includes
Resolves issues 👍
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Tested with forward.c in https://github.com/sdnfv/openNetVM/pull/199/files . ./style/run-lint.sh c outputs zero errors.

image

Review:

@kevindweb @dennisafa

onvm commented 4 years ago

In response to PR creation

CI Message

Your results will arrive shortly

kevindweb commented 4 years ago

Can we get a link to/screenshots of it passing the test cases for forward_tb.c?

bdevierno1 commented 4 years ago

Can we get a link to/screenshots of it passing the test cases for forward_tb.c?

I have added an image to the pr summary.

bdevierno1 commented 4 years ago

@kevindweb I have removed the comment bot from the branch job as well.

twood02 commented 4 years ago

sounds good to me