sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
263 stars 135 forks source link

DPDK Missing Python Dependencies #221

Closed sreyanalla closed 4 years ago

sreyanalla commented 4 years ago

Addresses DPDK Dependencies (Issue #161 )

Summary:

Resolves potential issues as described in #161 . All scripts/*.py files have been updated to use Python3 rather than Python2. Install.md was updated to include Python3 as a dependency and provides a guide on how to install it on your machine.

Usage:

This PR includes
Resolves issues #161
Breaking API changes
Internal API changes
Usability improvements
Bug fixes πŸ‘
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates πŸ‘
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Compiled the scripts/*.py files using Python3 and ran the manager with a few NFs to make sure expected output was achieved. I tried to create a bare metal profile with CloudLab so that I could specifically replicate the issue being resolved. The goal was to install ONVM on a machine without any version of python to ensure that the provided python installation instructions are fully functional and that the scripts run as intended.

onvm commented 4 years ago

In response to PR creation

CI Message

Aborting, need an authorized user to run CI

kevindweb commented 4 years ago

Thanks for working on this! I usually think it looks cleaner to write functions like this

print(args)

instead of

print (args)

Purely nitpicking but we probably want to be consistent if we're going to clean up these files.

bdevierno1 commented 4 years ago

Looks good to me πŸ‘ @sreya519

kevindweb commented 4 years ago

@onvm ci was aborted last time

onvm commented 4 years ago

@onvm ci was aborted last time

CI Message

Your results will arrive shortly

bdevierno1 commented 4 years ago

@onvm

onvm commented 4 years ago

@onvm

CI Message

Your results will arrive shortly