Closed sreyanalla closed 4 years ago
In response to PR creation
Aborting, need an authorized user to run CI
Thanks for working on this! I usually think it looks cleaner to write functions like this
print(args)
instead of
print (args)
Purely nitpicking but we probably want to be consistent if we're going to clean up these files.
Looks good to me π @sreya519
@onvm ci was aborted last time
@onvm ci was aborted last time
Your results will arrive shortly
@onvm
@onvm
Your results will arrive shortly
Addresses DPDK Dependencies (Issue #161 )
Summary:
Resolves potential issues as described in #161 . All
scripts/*.py
files have been updated to use Python3 rather than Python2.Install.md
was updated to include Python3 as a dependency and provides a guide on how to install it on your machine.Usage:
Merging notes:
TODO before merging :
Test Plan:
Compiled the
scripts/*.py
files using Python3 and ran the manager with a few NFs to make sure expected output was achieved. I tried to create a bare metal profile with CloudLab so that I could specifically replicate the issue being resolved. The goal was to install ONVM on a machine without any version of python to ensure that the provided python installation instructions are fully functional and that the scripts run as intended.