sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
263 stars 135 forks source link

MAC address fix #223

Closed catherinemeadows closed 4 years ago

catherinemeadows commented 4 years ago

Fixes the load_generator bug mentioned in #222

Summary:

In order to resolve the issue where the "Failed to obtain MAC address" error is raised in the load_generator NF, the function onvm_get_fake_macaddr() is used to obtain a fake MAC address for testing or in the case that the provided MAC address of the port is not bound to DPDK.

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes 👍
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Ran the load_generator NF with the MAC address of the node I am testing with. I had @sreya519 run this fix for the load_generator as well since she experienced this error.

Review:

@sreya519 --> tested the load_generator fixes already

onvm commented 4 years ago

In response to PR creation

CI Message

Your results will arrive shortly

onvm commented 4 years ago

In response to PR creation

CI Message

Error: ERROR: Failed to post results to GitHub

EthanBaron14 commented 4 years ago

@onvm try again?

onvm commented 4 years ago

@onvm try again?

CI Message

Your results will arrive shortly

onvm commented 4 years ago

@onvm try again?

CI Message

Error: ERROR: Failed to post results to GitHub

catherinemeadows commented 4 years ago

@onvm is this working now?

onvm commented 4 years ago

@onvm is this working now?

CI Message

Your results will arrive shortly

catherinemeadows commented 4 years ago

speed_tester has the same setup. Should we add the same print to it as well? @dennisafa

kevindweb commented 4 years ago

@catherinemeadows I think it would be useful to have a print statement like this one in speed_tester

dennisafa commented 4 years ago

Agreed - sorry I missed this comment. A comment wherever we fake it is a good idea.