Closed rohit-mp closed 4 years ago
In response to PR creation
Aborting, need an authorized user to run CI
@onvm how fast can you go?
@onvm how fast can you go?
Your results will arrive shortly
Hey @koolzz , thanks for your suggestions. I've made the corresponding changes.
Hi @twood02 Can I add default callback mode and divide the NF into different files in this PR itself? Or would it be better to create a separate PR after this one gets merged?
@rohit-mp - we plan to merge this PR soon. We can do the separate variations later. Thanks!
@rohit-mp yes good point, my mistake. Forgot about that.
Use NF data instead of global variables.
Before realizing that the compiler optimizes pointer references, I used local variables in the packet_handler. But then it just seemed neater and easier to read that way. Let me know if I should remove the local variables used there.
Summary:
Merging notes:
TODO before merging :
Test Plan:
Tested with new changes, the program works as before.
Review:
@twood02