search

sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
263 stars 135 forks source link

Use NF data instead of global variables. #224

Closed rohit-mp closed 4 years ago

rohit-mp commented 4 years ago

Use NF data instead of global variables.

Before realizing that the compiler optimizes pointer references, I used local variables in the packet_handler. But then it just seemed neater and easier to read that way. Let me know if I should remove the local variables used there.

Summary:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Tested with new changes, the program works as before.

Review:

@twood02

onvm commented 4 years ago

In response to PR creation

CI Message

Aborting, need an authorized user to run CI

kevindweb commented 4 years ago

@onvm how fast can you go?

onvm commented 4 years ago

@onvm how fast can you go?

CI Message

Your results will arrive shortly

rohit-mp commented 4 years ago

Hey @koolzz , thanks for your suggestions. I've made the corresponding changes.

rohit-mp commented 4 years ago

Hi @twood02 Can I add default callback mode and divide the NF into different files in this PR itself? Or would it be better to create a separate PR after this one gets merged?

twood02 commented 4 years ago

@rohit-mp - we plan to merge this PR soon. We can do the separate variations later. Thanks!

rohit-mp commented 4 years ago

onvm_nflib_stop() calls onvm_nflib_cleanup here which in turn frees the nf->data here. Is it necessary for me to manually free the data once again?

twood02 commented 4 years ago

@rohit-mp yes good point, my mistake. Forgot about that.