L2switch(l2fwd)

[bdevierno1]

Layer 2 switch based on dpdk's l2fwd example.

Summary:

The basic functionality of this NF will be the same as the l2fwd example provided by the DPDK It send out packets out the adjacent port and updates the mac address by default.

A good blog post about how this NF works. DPDK's explanation

To run the l2fwd dpdk example with two ports: sudo ./build/l2fwd -l 0-3 -n 4 -- -q 8 -p 3

I have added a flag which will print the mac address of each packet. This was used for debugging purposes. Likewise the NF also prints which port packets are being sent out from each port which is not in the original DPDK example.

Mac updating --enabled by default-- can be disabled with the -n flag. Printing of mac address can be enabled with the -m flag.

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args	👍
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

• Dependencies: None

TODO before merging :

• [👍 ] PR is ready for review

Test Plan:

• Tested packets are being sent out of the correct port.
• Tested mac address is correctly updated.
• Tested with pktgen --Note when using pktgen tx stats for the ports may not be updated correctly. This is a bug within the onvm mgr. --

NF Checklist:

• [x] Documentation describes purpose of NF, all arguments, and basic usage
• [x] NF stores all non-global state in a struct referenced by nf->data
• [x] NF performs initialization in a function_table->setup function and frees dynamic memory before exiting

Review:

@sreya519

[onvm]

In response to PR creation

CI Message

Your results will arrive shortly

[twood02]

@bdevierno1 I've added a checklist to the bottom of your PR message - can you verify you follow all of these?

[twood02]

@sreyanalla will do a final test then this is ready

[twood02]

rename to l2fwd to be consistent with DPDK

[dennisafa]

rename to l2fwd to be consistent with DPDK

Once you do this, I'll merge.

[dennisafa]

@onvm .

[onvm]

@onvm .

CI Message

Your results will arrive shortly

[onvm]

@onvm .

CI Message

Error: Failed to fetch results from nimbnode23

[dennisafa]

@onvm pls

[onvm]

@onvm pls

CI Message

Your results will arrive shortly

[onvm]

@onvm pls

CI Message

Error: Failed to fetch results from nimbnode23

[kevindweb]

@onvm again

[onvm]

@onvm again

CI Message

Your results will arrive shortly

[onvm]

@onvm again

CI Message

Error: Failed to fetch results from nimbnode23

[kevindweb]

For whoever needs it, this is why we're failing

[dennisafa]

Thats weird, I merged the DPDK update before this run. Is there a lag?

On Sun, Aug 2, 2020 at 12:33 PM Kevin Deems notifications@github.com wrote:

[image: Screen Shot 2020-08-02 at 12 32 44 PM] https://user-images.githubusercontent.com/24497157/89127563-54363400-d4bc-11ea-8cc7-b4e5413696f1.png For whoever needs it, this is why we're failing

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sdnfv/openNetVM/pull/230#issuecomment-667695918, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3EIZUCMBZZ2KLYGV5DXVTR6WIPDANCNFSM4N4PK2HA .

[kevindweb]

Thats weird, I merged the DPDK update before this run. Is there a lag? … On Sun, Aug 2, 2020 at 12:33 PM Kevin Deems @.***> wrote: [image: Screen Shot 2020-08-02 at 12 32 44 PM] https://user-images.githubusercontent.com/24497157/89127563-54363400-d4bc-11ea-8cc7-b4e5413696f1.png For whoever needs it, this is why we're failing — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#230 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3EIZUCMBZZ2KLYGV5DXVTR6WIPDANCNFSM4N4PK2HA .

I'm not sure, I haven't run this yet, but I would try to test this as CI does. Maybe delete your local l2switch branch, and pull it in again. Try remaking everything, and see if you get the error.

[dennisafa]

Thats weird, I merged the DPDK update before this run. Is there a lag? … On Sun, Aug 2, 2020 at 12:33 PM Kevin Deems @.***> wrote: [image: Screen Shot 2020-08-02 at 12 32 44 PM] https://user-images.githubusercontent.com/24497157/89127563-54363400-d4bc-11ea-8cc7-b4e5413696f1.png For whoever needs it, this is why we're failing — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#230 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3EIZUCMBZZ2KLYGV5DXVTR6WIPDANCNFSM4N4PK2HA .

I'm not sure, I haven't run this yet, but I would try to test this as CI does. Maybe delete your local l2switch branch, and pull it in again. Try remaking everything, and see if you get the error.

Makes sense - this branch isnt merged with the latest dev branch yet. @bdevierno1 if you could just pull the latest dev changes into this branch we can get the tests to pass.

[bdevierno1]

Thats weird, I merged the DPDK update before this run. Is there a lag? … On Sun, Aug 2, 2020 at 12:33 PM Kevin Deems @.***> wrote: [image: Screen Shot 2020-08-02 at 12 32 44 PM] https://user-images.githubusercontent.com/24497157/89127563-54363400-d4bc-11ea-8cc7-b4e5413696f1.png For whoever needs it, this is why we're failing — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#230 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3EIZUCMBZZ2KLYGV5DXVTR6WIPDANCNFSM4N4PK2HA .

I'm not sure, I haven't run this yet, but I would try to test this as CI does. Maybe delete your local l2switch branch, and pull it in again. Try remaking everything, and see if you get the error.

Makes sense - this branch isnt merged with the latest dev branch yet. @bdevierno1 if you could just pull the latest dev changes into this branch we can get the tests to pass.

@dennisafa @dennisafa sorry about that I should have left a comment sating that this will fail without pulling the latest updates.

[bdevierno1]

@onvm test l2fwd

[onvm]

@onvm test l2fwd

CI Message

Your results will arrive shortly