sdras / vue-vscode-snippets

These snippets were built to supercharge my workflow in the most seamless manner possible.
https://marketplace.visualstudio.com/items?itemName=sdras.vue-vscode-snippets
MIT License
1.33k stars 185 forks source link

bug in beforeEach and afterEach? #60

Closed epfromer closed 4 years ago

epfromer commented 5 years ago

First off, excellent set of snippets, thank you.

I'm walking through them all, and think I may have found bugs in beforeEach and afterEach for the Vue Router set.

I believe each should have a closing paren to match the opening. That is, for beforeEach:

"Vue Router beforeEach": { "prefix": "vbeforeeach", "body": [ "router.beforeEach((to, from, next) => {", "\t${1:next();}", "};" ], "description": "Vue Router global guards beforeEach" },

should be:

"Vue Router beforeEach": { "prefix": "vbeforeeach", "body": [ "router.beforeEach((to, from, next) => {", "\t${1:next();}", "});" ], "description": "Vue Router global guards beforeEach" },

zwik commented 4 years ago

As @sdras merged my PR, this should be resolved. There's a new release as well so if you update your extension you should be fine.

sdras commented 4 years ago

Thanks!