search

seamapi / fake-seam-connect

Fake for Seam Connect.
https://fake-seam-connect.seam.vc
MIT License
0 stars 0 forks source link

Support personal access tokens #126

Open razor-x opened 1 year ago

razor-x commented 1 year ago

See also https://github.com/seamapi/nextlove/pull/124 and https://github.com/seamapi/fake-seam-connect/issues/124

stale[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

andrii-balitskyi commented 4 days ago

@razor-x we have withAccessToken middleware. The fake also supports pat_with_workspace and pat_without_workspace [source]. What else this issue requires to be implemented?

razor-x commented 3 days ago

@andrii-balitskyi Yea, the auth methods were added in an earlier PR but were not tested properly or working. Getting these tests to pass is the first step in verifying those auth methods work https://github.com/seamapi/javascript-http/pull/150/files#diff-8f55516b1f0506eb134563710a3c6be8690e5f149de0810491a634f536fbcd4c

We should have basic tests in this repo to test those auth methods so we don't find out they are broken when trying to test the SDK.