sean-cc / jain-slee

Automatically exported from code.google.com/p/jain-slee
0 stars 0 forks source link

fireEvent() should return false when inside Exception #113

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
We have feedback in 
https://groups.google.com/forum/#!topic/mobicents-public/jr4cO2NP6Gg (messages 
from end of Aprel).
It looks like that - MAPResourceAdapter.fireEvent(String eventName, 
ActivityHandle handle, Object event, int flags)
should return false in case of Exception and true only if successed processing.

Original issue reported on code.google.com by serg.vet...@gmail.com on 1 May 2015 at 5:17

GoogleCodeExporter commented 9 years ago
I think we need to replace
try
{ sleeEndpoint.fireEvent(handle, eventID, event, address, null, flags); }
catch (UnrecognizedActivityHandleException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(IllegalEventException e) { this.tracer.severe("Error while firing event", e); }
catch (ActivityIsEndingException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(NullPointerException e) { this.tracer.severe("Error while firing event", e); }
catch (SLEEException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(FireEventException e) { this.tracer.severe("Error while firing event", e); }
return true;
with
} else {
try
{ sleeEndpoint.fireEvent(handle, eventID, event, address, null, flags); return 
true; }
catch (UnrecognizedActivityHandleException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(IllegalEventException e) { this.tracer.severe("Error while firing event", e); }
catch (ActivityIsEndingException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(NullPointerException e) { this.tracer.severe("Error while firing event", e); }
catch (SLEEException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(FireEventException e) { this.tracer.severe("Error while firing event", e); }
return false;
}

Original comment by serg.vet...@gmail.com on 1 May 2015 at 5:17