search

seandepagnier / weather_routing_pi

weather routing plugin for opencpn
GNU General Public License v3.0
47 stars 35 forks source link

Polar speed #220

Closed did-g closed 6 years ago

did-g commented 6 years ago

Hi, Wind from current was computed with the wrong sign, tested by forcing wind to zero both with grib and climatology.

I'm not sure about e4d5c48 and 30efb64

e4d5c48 : if I have two polars a : 0-6 and b : 6-xx InsideCrossOverContour wrongly returns 5.999 is inside 6-xx contour but not speed can be found later.

30efb64 : 0. is rejected by InsideCrossOverContour even if there's a contour.

Regards Didier

rgleason commented 6 years ago

Did-g, What do you mean "I'm not sure about e4d5c48 and 30efb64?" Not ready for merge? Need improvement?

did-g commented 6 years ago

rlgreason,

Patches don't need more work if what they solved are actual issues, but I'm not sure what is exactly tCrossOverContour logic intend.

For example Is 0-6 ,6-25 a valid setup? If yes patch is good.

Didier

seandepagnier commented 6 years ago

they are intended to overlap, so 0-6 and 4-25... if you had 0-6 and 6-25 it is likely there is a "gap" in some interpolations possibly causing propagations to be missed.