seandepagnier / weather_routing_pi

weather routing plugin for opencpn
GNU General Public License v3.0
47 stars 35 forks source link

ADD apparent wind for WindBarbsOnRoute #224

Closed theeko74 closed 6 years ago

theeko74 commented 6 years ago

Change from true wind direction and speed to apparent wind direction and speed as it is the conditions that we have on the boat... For example, it helps to see if we can do upwind or not.

rgleason commented 6 years ago

Sounds reasonable to me. Does it conflict with anything else in the plugin? The grib files show True wind. The boat feathers at optimal route would now show Apparent?

theeko74 commented 6 years ago

Yes, before WindBbarbOnRoute was showing True wind (direction and speed). I think this is more interesting to display Apparent Wind (direction and speed). For example, before if you see wind coming from side (90°) then when you are sailing you see wind coming from 70° because of the boat speed. So people think prevision was not correct...

theeko74 commented 6 years ago

This will not impact any thing in the plugin as it is only related to WindBarbOnRoute option.

rgleason commented 6 years ago

I hope Sean will merge. Thank you. I'll add a note in manual when he does so.

seandepagnier commented 6 years ago

It is supposed to show true wind, not apparent wind.

On 9/6/18, Rick Gleason notifications@github.com wrote:

I hope Sean will merge. Thank you. I'll add a note in manual when he does so.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/seandepagnier/weather_routing_pi/pull/224#issuecomment-419061716

theeko74 commented 6 years ago

You're right @seandepagnier can you tell me if this is fix now and showing apparent wind (and not true wind)? Thanks

seandepagnier commented 6 years ago

I don't have a problem to make this a display option, but by default, wind barbs rendered on the chart are understood to mean true wind, not apparent wind.

theeko74 commented 6 years ago

OK, this is now an option + WindBarbsOnRoute have a blue color to distinguish from default true wind. What do you think?

theeko74 commented 6 years ago

By the way @seandepagnier I am sorry but the other PR #226 includes the old version of apparent windBarbsOnRoute... If you merge this PR this should solve it.