search

seandepagnier / weather_routing_pi

weather routing plugin for opencpn
GNU General Public License v3.0
47 stars 35 forks source link

Route2 #243

Closed did-g closed 5 years ago

did-g commented 5 years ago

Hi

As noticed by Gilletarom we know from and to. Add them to exported track. Next step: export as a route with speed informations.

Regards Didier

rgleason commented 5 years ago

I've tried this PR.

  1. refactor export track before switching to route - yes the time seems to match properly. See screenshot.

  2. export set route start and end text - I don't understand this, it exports Tracks..

  3. use right time in position dialogue - yes it is. Screenshot (24)

  4. only display existing plot position - sorry don't understand what changed here.

  5. replace wsinx:nam by std::isnan - Yes

  6. RouteMapOverlay::Render thinko display endpoint cross if end not NAN … - Not sure what this is.

  7. backport from O: plugin don't need WxSVG/svg.h - Something funny is happening with this I think. When I turn off weather_routing, the Icon becomes a blank! Same thing happens with tactics and vdr record. See image. Screenshot (26) Slowly they Disappear. Screenshot (27) Then if I want them back hit the Bars att the top of the menu twice and it rewrites.

I don't think this should happen, and it is because you they aren't being rewriten for some reason? not svg? Is this some bug because we don't have dark flat MUI icons?

"Next step: export as a route with speed informations." I don't think this is done yet. I find no Route.

rgleason commented 5 years ago

Sean, I think this should be merged. I don't think the dropped out non Mui icons issue is related to the plugin.

rgleason commented 5 years ago

Thanks Sean for this merge and Pavels Mui, and Mac.

Hope you're well. I am looking forward to good weather.