seandepagnier / weather_routing_pi

weather routing plugin for opencpn
GNU General Public License v3.0
47 stars 35 forks source link

WIP Route analysis and bugfix. #249

Closed did-g closed 5 years ago

did-g commented 5 years ago

Hi, Add the ability to compute speed along an existing route.

Regards Didier

rgleason commented 5 years ago

Didier, This is a big important change. What a huge contributor you are! All users will thank you! WR Route --> Track --> Route Manager JSON message to request Grib Values Add SOG to route position I am sure there are other things I have not noticed. The plugin works well. This is an aside, there are a couple of things I have noticed in the past that are a little flakey:

I have some screen shots to show a little what I did. First completed a new routing. Screenshot (71)

Screenshot (72)

Screenshot (76)

Screenshot (74)

Screenshot (75)

I really need to check this one out more.

isochron reaching end point, set the right timespan

rgleason commented 5 years ago

Different Leg Speed & Arrival Dates for Track and Route. I feel guilty showing this after all the improvements!

Screenshot (77)

seandepagnier commented 5 years ago

wow, I intend to merge in a few days, give me time to review this

rgleason commented 5 years ago

Also this resolves the speed confusion in FR #248

did-g commented 5 years ago

Two things

On Fri, May 17, 2019 at 2:31 PM Rick Gleason notifications@github.com wrote:

Also this resolves the speed confusion in FR #248 https://github.com/seandepagnier/weather_routing_pi/issues/248

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/seandepagnier/weather_routing_pi/pull/249?email_source=notifications&email_token=AC4TMKTGMDIDQBCKO275AA3PV2QSBA5CNFSM4HNQJBTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVUT35Q#issuecomment-493436406, or mute the thread https://github.com/notifications/unsubscribe-auth/AC4TMKWJRNK3MPYHCSFTG7TPV2QSBANCNFSM4HNQJBTA .

rgleason commented 5 years ago

Related to this improvement: UI Improvement: Provide a yellow box "Info" tooltip at the Cursor along the Optimal Route #177

rgleason commented 5 years ago

Related to this improvement: Feature Request: Grib Weather at current Optimal Route Position (option) checkbox #203

rgleason commented 5 years ago

I suppose this is piling onto Didier, which is unfair, but this little bug needs a fix too: ov50 - Bug - wx-Routing requires Climatology_pi installed to be able to disable Climatology use. #241

did-g commented 5 years ago

@rgleason about

isochron reaching end point, set the right timespan

for computing legs speed WR is using distance/time with time being the configured step, but it doesn't work for the last leg. Let say you have a 3h hours step but you reach the end point in 1 hour, last leg speed is distance/1h not distance/3h

rgleason commented 5 years ago

Ah. Ha. The light bulb just turned on. Thanks. This is very similar to the solution "Slow Route", but it is an ending or completing case, rather than starting in the middle of constrained land areas, and going through mid route land areas.

Is there some "slow route" code that could be used for begining, middle and end, when in constrained areas.

seandepagnier commented 5 years ago

@rgleason about

isochron reaching end point, set the right timespan

for computing legs speed WR is using distance/time with time being the configured step, but it doesn't work for the last leg. Let say you have a 3h hours step but you reach the end point in 1 hour, last leg speed is distance/1h not distance/3h

Do you mean the propagate to end routine? Yes, the weather route has a special update just to reach the end position which it uses to compute the time to reach it rather than moving a fixed time step.

rgleason commented 5 years ago

Thank Sean, This seems like a very similar problem to various "Failures" at the start and middle of routes....something, some set of parameters for calculation have to be modified, in order to continue the calculation to completion (IE reaching Finish). So I ask this again...

Is there some "slow route" code that could be used for beginning, middle and end, when in constrained areas.

If this were possible and works better, then identifyng "failure types" might become less important.

did-g commented 5 years ago

@seandepagnier This fixes a display issue not a computation one. master bad speed PR right speed

rgleason commented 5 years ago

Tested. Please see http://www.cruisersforum.com/forums/f134/weather-routing-100060.html#post2892375 At various Climatology and Grib data created Isochrones Screenshot (89) Screenshot (90) Screenshot (91) Screenshot (92) Screenshot (93) Screenshot (94) Screenshot (95) Screenshot (96) Screenshot (97) Screenshot (98)

rgleason commented 5 years ago

From my forum notes...

Didier, I tested the plugin you reference above. Oddly, the SOG and SOW do not show together as in your screenshot. Do I need to adjust a setting?

Well I turned on average speed and average speed ground. (I don't think these settings control the "Route Positon" Panel. I believe they control the parameters shown in the Configurations area.

Then I discovered several things:

  1. Weather_routing seems to favor the left panel. Properly showing the isochrones as they are created. The right panel is not drawn until the route is completed.
  2. Grib_pi seems to favor the right panel, showing the grib wind indications in that panel only.
  3. Climatology_pi seems to do any panel that has been activated, and then the Wind Roses show.
  4. When "View > Route Position" is activated and hover over Climatology sourced data/isochrones the SOG and SOW show on various isochrones, but not all of them. Some are left out, - is this because of interopolation?
  5. When "View > Position" is activated and hover over Grib sourced data/isochrones the Boat Speed SOG is the only parameter that seems to show.

Can someone please confirm this and report back using Didier's appveyor "Artifact Tab" build of the plugin above? https://ci.appveyor.com/project/sean...5223/artifacts