seankwilliams / modern-footnotes

WordPress plugin to provide inline footnotes inspired by the styles of Grantland and FiveThirtyEight
14 stars 10 forks source link

Footnotes are not highlighted by default in the editor #53

Closed xibe closed 8 months ago

xibe commented 1 year ago

Hi @seankwilliams , and thanks for this plugin which I'm happy to use for side-tracks and inline humor :)

With the latest release of WordPress (version 6.3), footnotes are not highlighted by default in the editor:

image

The author has to click the footnote in order to see how wide it is:

image

I don't know how hard or easy of a fix this could be, but it would be great to have that highlight back.

Thank you very much!

seankwilliams commented 1 year ago

Hi @xibe ,

Thanks for pointing this out! I'm trying to replicate, and I'm still seeing the highlighting in WordPress 6.3.1 in the post editor:

image

Any ideas on how I could replicate? I see you have a different overall background color than I do in my editor, so I wonder if there's a different page or area I need to check.

xibe commented 1 year ago

Thank you for you quick reply, Sean!

I'm using 6.3.1 as well.

I'm using the Twenty Twenty theme, and the editor just applies its style -- I didn't change anything on that side. I'm unsure whether this is tied to the theme, to Modern Footnotes or to WP itself, but what's certain is that the loss of non-select highlighted happened when I update to 6.3.

I would need to install a test version of WP with various themes in order to check other contexts.

xibe commented 1 year ago

Here are my tests with various default themes, in WP trunk (6.4-alpha-56548):

2023:

image

2022:

image

2021:

image

2020:

image

2019:

image

2017:

image

2016:

image

and when selecting:

image

In short, none of the latest default themes seem to highlight the footnotes by default anymore.

Next step would be to test with 6.2 :)

seankwilliams commented 1 year ago

Thanks @xibe ! I've been able to replicate this now. I'll work on a fix for this!

xibe commented 1 year ago

Fantastic, thanks a lot!

xibe commented 1 year ago

Hi Sean! Were you able to find a fix? Thank you very much!

xibe commented 9 months ago

Hi @seankwilliams!

The problem remains with WP 6.4.3 and Modern Footnotes 1.4.18 (yes I know, that version fixes a PHP warning, I'm just saying I'm up-to-date here :) .

Is the issue above fixable? Do you need more testcases?

Thank you!

seankwilliams commented 9 months ago

@xibe I've been able to replicate the issue, and fixing it is in my dev queue. I've had limited development bandwidth though, hence why it's taking a while. If you’re interested, I welcome any pull requests with a proposed fix. PRs are always welcome, and your contribution would be valuable.

xibe commented 9 months ago

Ah, I wish I could (as I did in the past), but even my PHP5 chops are rusty at best :)

seankwilliams commented 9 months ago

All good! I'll get this fixed in one of the future updates.

xibe commented 8 months ago

Hi @seankwilliams!

I have no explanation for this but, to paraphrase Poe Dameron, "somehow, footnotes returned".

image

I was writing yesterday and the footnote indicator wasn't there. Today it is there.

I have not updated WP nor the plugin itself. It's a mystery -- but a good one!

Maybe Firefox updated itself? I don't know what happened, but it works now 😅

seankwilliams commented 8 months ago

That is excellent news @xibe , thank you for updating me on that! Let's hope it doesn't mysteriously stop working again =)