Closed xibe closed 8 months ago
Hi @xibe ,
Thanks for pointing this out! I'm trying to replicate, and I'm still seeing the highlighting in WordPress 6.3.1 in the post editor:
Any ideas on how I could replicate? I see you have a different overall background color than I do in my editor, so I wonder if there's a different page or area I need to check.
Thank you for you quick reply, Sean!
I'm using 6.3.1 as well.
I'm using the Twenty Twenty theme, and the editor just applies its style -- I didn't change anything on that side. I'm unsure whether this is tied to the theme, to Modern Footnotes or to WP itself, but what's certain is that the loss of non-select highlighted happened when I update to 6.3.
I would need to install a test version of WP with various themes in order to check other contexts.
Here are my tests with various default themes, in WP trunk (6.4-alpha-56548):
2023:
2022:
2021:
2020:
2019:
2017:
2016:
and when selecting:
In short, none of the latest default themes seem to highlight the footnotes by default anymore.
Next step would be to test with 6.2 :)
Thanks @xibe ! I've been able to replicate this now. I'll work on a fix for this!
Fantastic, thanks a lot!
Hi Sean! Were you able to find a fix? Thank you very much!
Hi @seankwilliams!
The problem remains with WP 6.4.3 and Modern Footnotes 1.4.18 (yes I know, that version fixes a PHP warning, I'm just saying I'm up-to-date here :) .
Is the issue above fixable? Do you need more testcases?
Thank you!
@xibe I've been able to replicate the issue, and fixing it is in my dev queue. I've had limited development bandwidth though, hence why it's taking a while. If you’re interested, I welcome any pull requests with a proposed fix. PRs are always welcome, and your contribution would be valuable.
Ah, I wish I could (as I did in the past), but even my PHP5 chops are rusty at best :)
All good! I'll get this fixed in one of the future updates.
Hi @seankwilliams!
I have no explanation for this but, to paraphrase Poe Dameron, "somehow, footnotes returned".
I was writing yesterday and the footnote indicator wasn't there. Today it is there.
I have not updated WP nor the plugin itself. It's a mystery -- but a good one!
Maybe Firefox updated itself? I don't know what happened, but it works now 😅
That is excellent news @xibe , thank you for updating me on that! Let's hope it doesn't mysteriously stop working again =)
Hi @seankwilliams , and thanks for this plugin which I'm happy to use for side-tracks and inline humor :)
With the latest release of WordPress (version 6.3), footnotes are not highlighted by default in the editor:
The author has to click the footnote in order to see how wide it is:
I don't know how hard or easy of a fix this could be, but it would be great to have that highlight back.
Thank you very much!