search

seaside1 / jrule

openHAB Java Rules Engine
Eclipse Public License 2.0
29 stars 15 forks source link

Dynamic rules #177

Closed seaside1 closed 12 months ago

seaside1 commented 1 year ago

Updated pull request. For dynamic rules

seaside1 commented 1 year ago

I've done these changes in order to dynamically generate rules and items. See https://github.com/seaside1/jrule-sonos for an example of how it can be used.

kuimovvg commented 1 year ago

It looks good, but in addition to the method of adding dynamic rules, you need a method for removing these rules.

seaside1 commented 1 year ago

It looks good, but in addition to the method of adding dynamic rules, you need a method for removing these rules.

When would you like to do this? I mean if you have a use-case?

kuimovvg commented 1 year ago

now doing it in https://github.com/seaside1/jrule/pull/178

kuimovvg commented 1 year ago

Something like this fb997f62703642a1e723d08cf941aa6cb5aaa624

seaside1 commented 1 year ago

@querdenker2k Would be good to get a review on this, so we can merge and then continue building on the dynamic rules.

seaside1 commented 12 months ago

I'm merging this due to now review other than querdenker2k comment above.