seb-oss / green

Green is an open-source design system built by SEB.
https://storybook.seb.io/
Apache License 2.0
37 stars 55 forks source link

RadioButton: is-invalid #1605

Open SEBEric opened 2 months ago

SEBEric commented 2 months ago

Bug already reported?

For which framework/library you are reporting the bug

No response

Component name

radiobutton

Description

invalid radiobuttons looks the same (but they do get the class 'is-invalid') in chlorophyll

Steps To Reproduce

go to https://storybook.seb.io/latest/chlorophyll/?path=/story/components-form-elements-radio-button--radiobutton&args=text1:Radiobutton+122;validation:is-invalid and take a look

Current Behaviour

-

Expected Behaviour

-

EldRoos commented 1 month ago

In this React RadioGroup example the red border comes because the outer div (2 steps out) have the class is-invalid. https://storybook.seb.io/latest/react/iframe.html?viewMode=docs&id=components-form-radiogroup--docs&args=#validation

Edit: Ok in the design the circle of the radio also becomes red. So this need to be changed in code.