Following our discussions in issue 176, here is my pull request for Grid size and position support.
I've also performed some minor corrections to avoid GHC compiler warnings and compilation failures with older version of GHC.
Some notes:
I've implemented a '//' operator for the CSS '/' operator. However, this operator is used in other CSS properties (background and font are the ones I know of). So, it's not fully coherent with the rest of the library. On the other hand, I find the syntax rather nice and natural (more than using tuples, especially because I already use them when a custom-ident is combined with an Integer).
There are spaces between the the '/' and its parameters (1 / 2) which is not removed when rendered in compact form. However, I feel this should more be the job of the compact rendering to remove them (but maybe I'm missing something here)
To properly implement all the naming rules for the custom-ident is highly complex due to the escaping and Unicode rules. It would require a parser such as MegaParsec. RegExp would not really be a good solution, as it would be difficult to return valuable error messages to the user. Adding a dependency for this only purpose is not worth it in my opinion.
Hello,
Following our discussions in issue 176, here is my pull request for Grid size and position support. I've also performed some minor corrections to avoid GHC compiler warnings and compilation failures with older version of GHC.
Some notes:
Let me know your thoughts.