sebfz1 / wicket-jquery-ui

jQuery UI & Kendo UI integration in Wicket
http://www.7thweb.net/wicket-jquery-ui/
Other
92 stars 58 forks source link

Allow usage of IndicatingAjaxButton with <input type="button"> #359

Open martin-g opened 1 year ago

martin-g commented 1 year ago

A user reported an issue at users@wicket.apache.org that IndicatingAjaxButton could not be used with <input type="button">:

WARN  - 28 Jun 2023 07:35:56,704 - IndicatingAjaxButton       - IndicatingAjaxButton should be applied on a 'button’ tag

citation:

Looking at the wicket source, I see:

public abstract class IndicatingAjaxButton extends AjaxButton

@Override
protected void onComponentTag(ComponentTag tag)
{
  super.onComponentTag(tag);
  if (!"button".equalsIgnoreCase(tag.getName()))
  {
    LOG.warn("IndicatingAjaxButton should be applied on a 'button' tag”);
  }
}

It appeared that he is using com.googlecode.wicket.jquery.ui.form.button.IndicatingAjaxButton.

Full discussion at https://lists.apache.org/thread/n934jywv4pbmpkbnkqsl9m24wqcgyzhk

sebfz1 commented 1 year ago

Hi Martin,

Yes, I have seen the discussion but I didn't understood it was about wicket-jquery-ui. In the case of the IndicatingAjaxButton, it doesn't work if it's in input, the spinner will not be displayed, AFAIR...

On Thu, Jun 29, 2023, 20:26 Martin Grigorov @.***> wrote:

A user reported an issue at @.*** that IndicatingAjaxButton could not be used with :

WARN - 28 Jun 2023 07:35:56,704 - IndicatingAjaxButton - IndicatingAjaxButton should be applied on a 'button’ tag

citation:

Looking at the wicket source, I see:

public abstract class IndicatingAjaxButton extends AjaxButton

@Override protected void onComponentTag(ComponentTag tag) { super.onComponentTag(tag); if (!"button".equalsIgnoreCase(tag.getName())) { LOG.warn("IndicatingAjaxButton should be applied on a 'button' tag”); } }

It appeared that he is using com.googlecode.wicket.jquery.ui.form.button.IndicatingAjaxButton.

Full discussion at https://lists.apache.org/thread/n934jywv4pbmpkbnkqsl9m24wqcgyzhk

— Reply to this email directly, view it on GitHub https://github.com/sebfz1/wicket-jquery-ui/issues/359, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANDHGBSW7R5MECAWLUTS7DXNVYA3ANCNFSM6AAAAAAZYOCKCA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

martin-g commented 1 year ago

If it does not support <input type="button"> then please close this issue. I just wanted to make sure you are aware of the discussion.