seboettg / citeproc-php

Full-featured CSL 1.0.1 processor for PHP
MIT License
76 stars 39 forks source link

Error after upgrade to "seboettg/collection": "4.0.0" #181

Closed burki closed 11 months ago

burki commented 11 months ago

Attempted to call an undefined method named "hasKey" of class "Seboettg\Collection\ArrayList". at vendor\seboettg\citeproc-php\src\Locale\LocaleXmlParserTrait.php:132:

if ($child->getName() !== "name-part" && !$this->terms->hasKey($name)) {

Downgrading seboettg/collection (v4.0.0 => v3.1.0) solves the issue (keeping seboettg/citeproc-php at v2.6.1).

Please let me know if you need a minimal test case to reproduce this issue.

seboettg commented 11 months ago

Oh yes, version 4 of seboettg/collection has a lot of breaking changes. I'm going to make fix asap by fixating seboettg/collection to version 3.*.

seboettg commented 11 months ago

Done. Please check the hotfix release for citeproc-php.

burki commented 11 months ago

Solved by 4070bdc3ad1c5fa1cfe3887f2db70f281a50e4a7