secondlife / jira-archive

3 stars 0 forks source link

[BUG-234577] [PBR] - Overriding the base color tint with plain white is reverting to the assets color instead of white #11477

Open sl-service-account opened 1 year ago

sl-service-account commented 1 year ago

What just happened?

Changning the color of a PBR materials base color tint as an override with plain white (RGB 255) will reset the color tint to the color that has been saved in the original material asset rather than overriding it to white.

It looks like it's treating RGB 255 like the empty string that is used with LSL to revert to the original assets settings.

What were you doing when it happened?

1) Rez a sphere. 2) Create a new material in your inventory. 3) Open the material and set it's base color tint to red. Save the material. 4) Apply the material to the Sphere. 5) Select the sphere and edit the material. Click the base colors tint swatch. 6) Select the blue color swatch. Note that the color is overridden with blue. 7) Select the white color swatch. Note that the color is reverting to red instead of white.

What were you expecting to happen instead?

I would expect that the color white can be applied as an override.

Other information

Calling <1,1,1> as the color vector in PRIM_GLTF_BASE_COLOR does have the same effect as putting an empty string as the color vector. It's also reverting to the original assets color.

A short video is attached demonstrating the issue.

Attachments

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-234577 | | Summary | [PBR] - Overriding the base color tint with plain white is reverting to the assets color instead of white | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Triaged | | Labels | pbr | | Reporter | arton Rotaru (arton.rotaru) | | Created at | 2023-10-22T20:34:33Z | | Updated at | 2023-10-24T17:24:42Z | ``` { 'Build Id': 'unset', 'Business Unit': ['Platform'], 'Date of First Response': '2023-10-24T12:24:42.294-0500', "Is there anything you'd like to add?": "Calling <1,1,1> as the color vector in PRIM_GLTF_BASE_COLOR does have the same effect as putting an empty string as the color vector. It's also reverting to the original assets color.\r\n\r\nA short video is attached demonstrating the issue.", 'ReOpened Count': 0.0, 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': "Changning the color of a PBR materials base color tint as an override with plain white (RGB 255) will reset the color tint to the color that has been saved in the original material asset rather than overriding it to white.\r\n\r\nIt looks like it's treating RGB 255 like the empty string that is used with LSL to revert to the original assets settings.", 'What were you doing when it happened?': "1) Rez a sphere.\r\n2) Create a new material in your inventory.\r\n3) Open the material and set it's base color tint to red. Save the material.\r\n4) Apply the material to the Sphere.\r\n5) Select the sphere and edit the material. Click the base colors tint swatch.\r\n6) Select the blue color swatch. Note that the color is overriden with blue.\r\n7) Select the white color swatch. Note that the color is reverting to red instead of white.", 'What were you expecting to happen instead?': 'I would expect that the color white can be applied as an override.', 'Where': 'secondlife://Aditi/secondlife/Rumpus%20Room%2034/235/16/24', } ```
sl-service-account commented 1 year ago

JIRAUSER341268 commented at 2023-10-24T17:24:42Z

Thanks arton!