search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
212 stars 53 forks source link

[WebRTC] P2P voice calling a user who has voice disabled should report a decline to the calling user (on WebRTC regions.) #2278

Open roxanneskelly opened 3 months ago

roxanneskelly commented 3 months ago

Environment

(also applies to WebRTC RC candidate viewers, and maybe release viewers.)

Second Life Test 7.1.9.10357432793 (64bit) Release Notes

You are at 128.0, 127.8, 23.0 in vivox1 located at simhost-0ed8234b30a9d6270.aditi SLURL: secondlife://Aditi/secondlife/vivox1/128/128/23 (global coordinates 259,968.0, 245,632.0, 23.0) Second Life Server 2024-06-11.9458617693 Release Notes

CPU: Intel(R) Core(TM) Ultra 9 185H (3072 MHz) Memory: 32213 MB OS Version: Microsoft Windows 10/11 64-bit (Build 22631.3880) Graphics Card Vendor: NVIDIA Corporation Graphics Card: NVIDIA GeForce RTX 4060 Laptop GPU/PCIe/SSE2

Windows Graphics Driver Version: 32.0.15.5599 OpenGL Version: 4.6.0 NVIDIA 555.99

Window size: 1694x1064 Font Size Adjustment: 96pt UI Scaling: 1.05 Draw distance: 128m Bandwidth: 10000kbit/s LOD factor: 1.75 Render quality: 5 Texture memory: 7192MB Disk cache: Max size 3993.6 MB (100.0% used)

J2C Decoder Version: KDU v7.10.4 Audio Driver Version: FMOD Studio 2.02.20 Dullahan: 1.14.0.202310131404 CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54 Chromium: 118.0.5993.54 LibVLC Version: 3.0.16 Voice Server Version: Not Connected Packets Lost: 0/2,528 (0.0%) August 13 2024 10:22:30

Description

When making a p2p voice call to another resident who's voice is disabled, the calling user gets no automatic "declined" response and simply sits there with the 'calling' dialog up.

We should probably drop a message to the calling viewer that the peer has declined the call, or has voice disabled.

This happens in both WebRTC and Vivox regions.

Reproduction steps

  1. Bring up two viewers (A and B) in either a webrtc or vivox region.
  2. Disable voice on A, enable it on B
  3. start a P2P call from B to A.
  4. Observe: B's calling dialog just stays there, without any messaging that B cannot answer.

Expected: B should get a notification that either A has declined the call, or A has disabled voice.

LLGuru commented 1 month ago