secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
212 stars 53 forks source link

Sky presets have a lot more red light than expected. #2719

Open georgebproductengine opened 2 months ago

georgebproductengine commented 2 months ago

Steps to reproduce: 1.Log in to the Viewer. 2.Apply sky preset(e.g. Sheer Surreality , Sailor's Delight).

Actual result: Sky presets have a lot more red light than expected. So other colors are distorted and become more vibrant

Expected result: Sky presets need to be less saturated with red light

According to the Environment Rendering conformity test plan. Test: Sky presets - Test 1,2,6 screenshots.

Additional info: The issue is reproduced on the OSX/Win10. This issue is reproduced on production Second Life Release 7.1.10.10800445603 .

Actual screenshots
Screenshot 2024-09-27 at 14 46 42 Screenshot 2024-09-27 at 14 45 27
Expected screenshots
Screenshot 2024-09-27 at 14 55 24 Screenshot 2024-09-27 at 15 00 42

Environment


Second Life Release 7.1.11.10947335521 (64bit) Release Notes You are at 2.7, 15.4, 21.4 in Product Engine 3 located at simhost-06c92da1cee01d90f.agni SLURL: http://maps.secondlife.com/secondlife/Product%20Engine%203/3/15/21 (global coordinates 336643.0, 306959.0, 21.4) Second Life Server 2024-07-22.10048683488 Release Notes CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (2600 MHz) Memory: 16384 MB OS Version: macOS 14.5.0 Darwin 23.5.0 Darwin Kernel Version 23.5.0: Wed May 1 20:09:52 PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64 Graphics Card Vendor: ATI Technologies Inc. Graphics Card: AMD Radeon Pro 555X OpenGL Engine OpenGL Version: 4.1 ATI-5.5.17 Window size: 1140x777 Font Size Adjustment: 96pt UI Scaling: 1 Draw distance: 128m Bandwidth: 3000kbit/s LOD factor: 1.25 Render quality: 2 Texture memory: 4096MB Disk cache: Max size 1638.4 MB (22.3% used) HiDPI display mode: J2C Decoder Version: KDU v7.10.4 Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.23.1 / OpenAL Community / OpenAL Soft: OpenAL Soft Dullahan: 1.14.0.202408091638 CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54 Chromium: 118.0.5993.54 LibVLC Version: 3.0.21 Voice Server Version: Not Connected Packets Lost: 0/3783 (0.0%) September 27 2024 06:23:59
katerynamproductengine commented 1 month ago

This issue is also reproduced on Second Life Release 7.1.11.11074622243 (64bit) on location: http://maps.secondlife.com/secondlife/Lag%20Me%204/0/11/23 on AGNI and Face Northeast.

On this location, the applied “Gelatto” sky preset from Library/Environments/Skies looks greener than expected.

Actual screenshot: Screenshot 2024-10-04 at 2 47 18 PM
Expected screenshot: Screenshot 2024-10-04 at 2 41 12 PM

According the Environment Rendering conformity test plan. Test: Sky presets - Test 4/Test5 .

Additional info: The issue is reproduced on the OSX/Win10. This issue is reproduced on production Second Life Release 7.1.10.10800445603 .

AtlasLinden commented 1 month ago

Pre-PBR vs ExtraFPS comparison of Sheer Surreality EEP setting: image

AtlasLinden commented 1 month ago

Pre-PBR vs ACES: image

georgebproductengine commented 1 month ago

Failed QA

Verified on the Second Life Release 7.1.11.11469579464 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/374. Sky's look as actual with additional red light regardless of brightness(exposure) level.

valeriiaaproductengine commented 3 days ago

Failed QA.

The sky is still saturated with red color - see actual_7.1.11.12041172537_viewer.png screenshot. Environment: "Sheer Surreality" from Library/Environments/Skies.

Image

Verified on the Second Life Release 7.1.11.12041172537 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/401.

AtlasLinden commented 3 days ago

Here's a side-by-side comparison below. The clouds move rather fast in Sheer Surreality so it may not look exact. The colour can be seen to be slightly different but not nearly as different as it was using Khronos Neutral in the original report. May require additional review. Image

Edit: It seems the Tonemapping Mix slider is broken on the most recent ExtraFPS build 7.1.11.12041172537 tested here which may be causing this

Geenz commented 3 days ago

@AtlasLinden Tonemapping is no longer supported on legacy skies.

AtlasLinden commented 2 days ago

After review with product, this passes QA